Skip to content

docs(core): fix MetricsKind typo #21573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2024
Merged

docs(core): fix MetricsKind typo #21573

merged 2 commits into from
Oct 24, 2024

Conversation

nionata
Copy link
Contributor

@nionata nionata commented Oct 21, 2024 •
edited
Loading

Fix a typo in the MetricsKind doc comment.

@nionata nionata requested a review from a team as a code owner October 21, 2024 22:26
@bits-bot
Copy link

bits-bot commented Oct 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label Oct 21, 2024
@nionata nionata changed the title docs: fix MetricsKind typo docs(core): fix MetricsKind typo Oct 21, 2024
jszwedko
jszwedko approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nionata

@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 21, 2024
@jszwedko jszwedko enabled auto-merge October 21, 2024 22:34
@pront
Copy link
Member

pront commented Oct 22, 2024

I believe make generate-component-docs will fix the failing job.

@nionata
Copy link
Contributor Author

nionata commented Oct 22, 2024

I believe make generate-component-docs will fix the failing job.

Giving this a shot now

@pront pront requested review from a team as code owners October 24, 2024 17:08
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Oct 24, 2024
@jszwedko jszwedko added this pull request to the merge queue Oct 24, 2024
Merged via the queue into vectordotdev:master with commit 4d1f3fd Oct 24, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

@brinkap brinkap brinkap approved these changes

@estherk15 estherk15 estherk15 approved these changes

Assignees
No one assigned
Labels
domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nionata @bits-bot @pront @jszwedko @brinkap @estherk15