Skip to content

chore: Fix publish workflow for older OS images #17787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2023
Merged

chore: Fix publish workflow for older OS images #17787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,11 @@ jobs:
uses: actions/checkout@v3
with:
ref: ${{ inputs.git_ref }}
submodules: "recursive"
# Workaround for older OS images
# https://github.com/actions/checkout/issues/758
- name: Checkout submodules
run: |
git submodule update --init --recursive
Comment on lines +326 to +327
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
run: |
git submodule update --init --recursive
run: git submodule update --init --recursive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, I prefer using the pipe for intentionality given the general trickiness of YAML - but happy to change it if that's a dissenting opinion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np, can leave as is. curious though, in practice what aspect of yaml trickiness does this aid in circumventing ? I've been using the non-pipe for one liners in the other workflows

- name: Download staged package artifacts (x86_64-unknown-linux-gnu)
uses: actions/download-artifact@v3
with:
Expand Down