Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(statsd sink): refactor
statsd
sink to stream-based style #16199New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(statsd sink): refactor
statsd
sink to stream-based style #16199Changes from 29 commits
db9f4ca
e5280d9
a22763e
0ab950b
bacf1ff
a17e839
8609e9f
a08bc84
b32e933
6037898
f28379f
cd9fe58
8c1dd18
36f5627
577efa9
f67a09e
f0f531b
667ce41
2144849
78e633b
fe9a495
392c4d7
fce04a2
332dff2
7664aa7
35cde29
292b171
1373f1e
74d9bff
f6d7292
be7c5ef
d35bcf4
43b3c3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a curiosity not an issue - I noticed this is directly in
src/
and that we have some other files in there that could conceivably be placed in something like a "utils" folder or something similar. Just wondering if that has ever been brought up. On second look we have asrc/common
that might have a similar goal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this could/should actually live in
vector-core
.Ironically,
vector-core
already has a nearly identical file in there doing almost the exact same thing, but when I went to convert it all over, it felt like a lot of toil/change on top of an already large PR, and I felt like it would be an easy lay-up PR to follow up with.