Skip to content

docs(sinks): Remove partitioning docs #15723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

jszwedko
Copy link
Member

They were incorrectly showing up on all request-based sinks even though not all support dynamic
partitioning. Instead I just added additional pointers to the template docs with the options that
support templating.

Closes: #11242

Signed-off-by: Jesse Szwedko [email protected]

They were incorrectly showing up on all request-based sinks even though not all support dynamic
partitioning. Instead I just added additional pointers to the template docs with the options that
support templating.

Closes: #11242

Signed-off-by: Jesse Szwedko <[email protected]>
@netlify
Copy link

netlify bot commented Dec 23, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 2675721
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63a62299ec997c00087da8a2
😎 Deploy Preview https://deploy-preview-15723--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 23, 2022

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit 2675721
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/63a62299f50818000896ee97

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Dec 23, 2022
Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to make sure this works nicely with the generated docs as well

@jszwedko jszwedko merged commit 859fe61 into master Dec 23, 2022
@jszwedko jszwedko deleted the jszwedko/remove-partitioning-docs branch December 23, 2022 22:03
@jszwedko
Copy link
Member Author

We'll need to make sure this works nicely with the generated docs as well

True, in this case it is part of the website rendering rather than in the cue data, but I could see us changing that in the future to be driven from the config schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_kinesis_firehose sink documents that it supports partitioning, but it does not
2 participants