-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore(humio_metrics sink): add test for duplicate metrics #15620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Stephen Wakely <[email protected]>
✅ Deploy Preview for vector-project canceled.
|
✅ Deploy Preview for vrl-playground canceled.
|
Regression Test Results
Run ID: acefb0dd-41f0-4d5d-97b8-b137dd561d36 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Does the sink actually call into the |
FWIW At this point that |
src/sinks/humio/metrics.rs
Outdated
@@ -293,4 +293,47 @@ mod tests { | |||
output[1].1 | |||
); | |||
} | |||
|
|||
#[tokio::test] | |||
async fn duplicate_metrics() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this to test duplicate tags?
Also, should we converge on calling it multi-value tags or duplicate tags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been avoiding the term "duplicate" as the values are not duplicated, only the names.
It is calling into |
…cate_metrics_test
Signed-off-by: Stephen Wakely <[email protected]>
Regression Test Results
Run ID: 941a0ad6-ca43-47b1-ace1-d9ed82662c48 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second Kyle's concerns about terms but otherwise this LGTM.
Signed-off-by: Stephen Wakely <[email protected]>
Regression Test Results
Run ID: 7d0570bd-27ef-494b-8c15-6f47a8c4d405 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Closes #15619
Epic #15420
Humio doesn't really have the concept of metrics as a first class citizen, so duplicate tags should work fine. Since the Humio metrics sink is essentially just a combination of the
metric_to_log
transform and thehumio_logs
sink, this PR just adds a test to ensure that duplicate tags are encoded in a sensible manner (they become an array as per themetric_to_log
transform).Signed-off-by: Stephen Wakely [email protected]