enhancement(internal_events): add source identifier to specific internal events
#15499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
✅ Deploy Preview for vrl-playground canceled.
|
✅ Deploy Preview for vector-project canceled.
|
github-actions
bot
added
domain: core
Signed-off-by: Jean Mertz <[email protected]>
bruceg
reviewed
Dec 8, 2022
| @@ -10,25 +10,28 @@ pub struct EventsSent<'a> { | |||
| pub count: usize, | |||
| pub byte_size: usize, | |||
| pub output: Option<&'a str>, | |||
| pub source: Option<&'a str>, | |||
| } | |||
|
|
|||
| impl<'a> InternalEvent for EventsSent<'a> { | |||
There was a problem hiding this comment.
Note that this source has changed recently and no longer contains this implementation. You'll need to update against current master.
There was a problem hiding this comment.
Thanks! Yeah, I did find that out during a rebase this morning. I've got some time scheduled tomorrow to rectify this.
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
|
Superseded by #17549 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧