Skip to content

chore: Standardize on cfg(windows) #15000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2022
Merged

chore: Standardize on cfg(windows) #15000

merged 3 commits into from
Oct 31, 2022

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Oct 28, 2022

We have used both cfg(windows) and cfg(target_os = "windows") in a number of places. This picks the simpler form, which is equivalent to cfg(target_family = "windows") and related to cfg(unix) which we also use.

We have used both `cfg(windows)` and `cfg(target_os = "windows")` in a number of
places. This picks the simpler form, which is equivalent to
`cfg(target_family = "windows")` and related to `cfg(unix)` which we also use.
@bruceg bruceg added the type: tech debt A code change that does not add user value. label Oct 28, 2022
@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit ce29256
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/635fd917cc03740009a86977

@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Oct 28, 2022
@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit ce29256
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/635fd91779854600089d6e3f
😎 Deploy Preview https://deploy-preview-15000--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bruceg bruceg marked this pull request as ready for review October 28, 2022 17:43
@bruceg
Copy link
Member Author

bruceg commented Oct 28, 2022

FWIW I also intend to check which instances of cfg(target_os = "linux") could be just cfg(unix). I don't think there are many of those, though.

@bruceg bruceg added the ci-condition: integration tests enable Run integration tests on this PR label Oct 28, 2022
@github-actions
Copy link

Soak Test Results

Baseline: ac69a47
Comparison: ce29256
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_pipelines_blackhole_acks 10.1KiB 0.82 99.95% 1.2MiB 127.44KiB 2.59KiB 0 0.103346 1.21MiB 64.35KiB 1.31KiB 0 0.0517575 False False
datadog_agent_remap_blackhole 327.73KiB 0.56 99.92% 57.33MiB 3.82MiB 79.56KiB 0 0.0665844 57.65MiB 2.72MiB 56.66KiB 0 0.0470914 False False
splunk_hec_route_s3 109.62KiB 0.51 91.32% 20.98MiB 2.22MiB 46.16KiB 0 0.105699 21.08MiB 2.12MiB 44.31KiB 0 0.100417 False False
datadog_agent_remap_blackhole_acks 282.15KiB 0.47 99.47% 58.31MiB 4.05MiB 84.31KiB 0 0.0694345 58.58MiB 2.68MiB 55.99KiB 0 0.0457172 False False
http_text_to_http_json 122.45KiB 0.32 91.67% 37.23MiB 2.41MiB 50.22KiB 0 0.0645803 37.35MiB 2.38MiB 49.74KiB 0 0.0637143 False False
syslog_log2metric_splunk_hec_metrics 38.59KiB 0.23 97.79% 16.16MiB 465.14KiB 9.48KiB 0 0.0281109 16.19MiB 684.91KiB 13.94KiB 0 0.0412967 False False
syslog_splunk_hec_logs 22.82KiB 0.14 78.27% 15.46MiB 709.54KiB 14.45KiB 0 0.0448076 15.48MiB 565.15KiB 11.54KiB 0 0.0356378 False False
splunk_hec_indexer_ack_blackhole 22.28KiB 0.09 60.46% 23.74MiB 949.02KiB 19.3KiB 0 0.0390294 23.76MiB 872.05KiB 17.75KiB 0 0.0358311 False False
socket_to_socket_blackhole 17.34KiB 0.07 64.43% 22.99MiB 667.25KiB 13.62KiB 0 0.0283322 23.01MiB 632.66KiB 12.91KiB 0 0.0268437 False False
splunk_hec_to_splunk_hec_logs_acks 6.88KiB 0.03 21.93% 23.75MiB 867.8KiB 17.65KiB 0 0.0356775 23.76MiB 849.07KiB 17.27KiB 0 0.0348974 False False
syslog_humio_logs 2.58KiB 0.02 50.20% 16.1MiB 135.87KiB 2.77KiB 0 0.00823875 16.1MiB 126.94KiB 2.6KiB 0 0.00769628 False False
splunk_hec_to_splunk_hec_logs_noack -216.84B -0 1.72% 23.84MiB 341.74KiB 6.98KiB 0 0.0139967 23.84MiB 337.5KiB 6.89KiB 0 0.0138231 False False
enterprise_http_to_http 256.13B 0 2.71% 23.85MiB 252.75KiB 5.16KiB 0 0.0103488 23.85MiB 256.05KiB 5.24KiB 0 0.010484 False False
file_to_blackhole -52.17KiB -0.05 51.54% 95.37MiB 2.39MiB 49.53KiB 0 0.0250488 95.31MiB 2.69MiB 55.84KiB 0 0.0281668 False False
syslog_regex_logs2metric_ddmetrics -5.74KiB -0.07 18.88% 7.73MiB 831.19KiB 16.94KiB 0 0.104924 7.73MiB 835.91KiB 17.04KiB 0 0.105597 False False
http_to_http_json -35.02KiB -0.14 99.10% 23.85MiB 379.09KiB 7.74KiB 0 0.0155211 23.81MiB 535.42KiB 10.94KiB 0 0.0219531 False False
http_to_http_acks -38.96KiB -0.22 12.95% 17.43MiB 8.09MiB 169.15KiB 0 0.464118 17.39MiB 8.09MiB 168.9KiB 0 0.465209 True True
fluent_elasticsearch -214.38KiB -0.26 99.77% 79.47MiB 53.37KiB 1.08KiB 0 0.000655697 79.26MiB 3.41MiB 70.25KiB 0 0.0430753 False False
datadog_agent_remap_datadog_logs_acks -166.48KiB -0.26 85.50% 61.76MiB 3.28MiB 68.63KiB 0 0.0531679 61.6MiB 4.39MiB 91.3KiB 0 0.0711842 False False
http_to_http_noack -83.72KiB -0.34 99.97% 23.84MiB 414.82KiB 8.48KiB 0 0.0169914 23.75MiB 1.04MiB 21.6KiB 0 0.0435976 False False
http_pipelines_blackhole -6.85KiB -0.4 99.99% 1.68MiB 16.84KiB 352.21B 0 0.00979765 1.67MiB 81.14KiB 1.65KiB 0 0.0473903 False False
syslog_loki -92.98KiB -0.6 100.00% 15.14MiB 426.17KiB 8.73KiB 0 0.0274914 15.04MiB 813.01KiB 16.53KiB 0 0.052762 False False
syslog_log2metric_humio_metrics -61.7KiB -0.64 100.00% 9.42MiB 249.53KiB 5.09KiB 0 0.0258626 9.36MiB 426.74KiB 8.69KiB 0 0.0445137 False False
datadog_agent_remap_datadog_logs -494.13KiB -0.78 100.00% 62.22MiB 262.59KiB 5.37KiB 0 0.00412036 61.74MiB 4.4MiB 91.59KiB 0 0.0712544 False False
http_pipelines_no_grok_blackhole -113.27KiB -1.07 100.00% 10.33MiB 135.54KiB 2.77KiB 0 0.0128076 10.22MiB 993.78KiB 20.21KiB 0 0.0949251 False False

@bruceg bruceg merged commit a5d7cea into master Oct 31, 2022
@bruceg bruceg deleted the bruceg/standardize-cfg branch October 31, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-condition: integration tests enable Run integration tests on this PR domain: sources Anything related to the Vector's sources type: tech debt A code change that does not add user value.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants