-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: Standardize on cfg(windows)
#15000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We have used both `cfg(windows)` and `cfg(target_os = "windows")` in a number of places. This picks the simpler form, which is equivalent to `cfg(target_family = "windows")` and related to `cfg(unix)` which we also use.
✅ Deploy Preview for vrl-playground canceled.
|
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
FWIW I also intend to check which instances of |
Soak Test ResultsBaseline: ac69a47 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
We have used both
cfg(windows)
andcfg(target_os = "windows")
in a number of places. This picks the simpler form, which is equivalent tocfg(target_family = "windows")
and related tocfg(unix)
which we also use.