Skip to content

Remove 60s hard cutoff period for graceful shutdowns #9042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jszwedko opened this issue Sep 3, 2021 · 2 comments
Closed

Remove 60s hard cutoff period for graceful shutdowns #9042

jszwedko opened this issue Sep 3, 2021 · 2 comments
Labels
domain: shutdown Anything related to the shutdown of Vector type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@jszwedko
Copy link
Member

jszwedko commented Sep 3, 2021

A user mentioned they'd prefer Vector just try to flush forever and they can decide when to hard terminate Vector. This strikes me as reasonable.

This could be a configurable option if we want to preserve the current behavior as well.
@jszwedko jszwedko added type: enhancement A value-adding code change that enhances its existing functionality. domain: topology Anything related to Vector's topology code domain: shutdown Anything related to the shutdown of Vector and removed domain: topology Anything related to Vector's topology code labels Sep 3, 2021
@spencergilbert
Copy link
Contributor

Configurable would be good - with a default, so we can set a default in our helm charts but allow overrides as well 😄

@jszwedko jszwedko mentioned this issue Feb 15, 2022
Closed
@jszwedko jszwedko mentioned this issue May 24, 2022
Closed
@DominicBurkart DominicBurkart mentioned this issue May 24, 2023
Merged
DominicBurkart added a commit that referenced this issue Jun 1, 2023
@DominicBurkart @bruceg
feat(configurable shutdown duration): make shutdown duration configur…
23ed0e3 
…able (#17479)

We want to make the graceful shutdown period configurable instead of
hardcoding it to sixty seconds.

Issues:
#9042 Remove 60s hard
cutoff period for graceful shutdowns
#12831 Want to adjust
graceful shutdown time

This is my first PR in vector, not sure if this is the correct approach:
- are the ergonomics (-1 for no timeout, 0+ for timeout durations) good?
- any test recommendations beyond manual testing?

---------

Co-authored-by: Bruce Guenter <[email protected]>
@jszwedko
Copy link
Member Author

jszwedko commented Aug 2, 2023

Closed by #17479

@jszwedko jszwedko closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: shutdown Anything related to the shutdown of Vector type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jszwedko @spencergilbert