feat(vector): Support tpl for init and extra containers. #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for templated content in both initContainers and extraContainers and updates the chart version.
- Updated comments in values.yaml to indicate template support for container configurations.
- Bumped the chart version in Chart.yaml to reflect recent changes.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/vector/values.yaml | Added comments noting that initContainers and extraContainers now support template content. |
| charts/vector/Chart.yaml | Bumped the version from 0.41.1 to 0.41.2. |
Files not reviewed (1)
- charts/vector/templates/_pod.tpl: Language not supported
Comments suppressed due to low confidence (2)
charts/vector/values.yaml:375
- [nitpick] The commented-out initContainers sample block duplicates the key name, which may cause confusion. Consider clarifying its purpose or removing it if it's only meant for future reference.
# initContainers:
charts/vector/values.yaml:390
- [nitpick] The commented-out extraContainers sample block duplicates the key name, potentially leading to ambiguity. Consider clarifying the intended usage or removing the redundant example.
# extraContainers:
pront
reviewed
Mar 27, 2025
JaredTan95
changed the title
auto-merge was automatically disabled
March 29, 2025 01:11
Head branch was pushed to by a user without write access
|
hi @pront ,May I ask how long is the release cycle? When will this PR content be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support tpl in extraContainers and initContainers.