Prevent out of memory when parsing malformed sub-programs

[Alan-Jowett]

If the subprogram being processed is the same as the current program, then the logic to copy the line-info entries performs an unbounded allocation.

Summary by CodeRabbit

• Bug Fixes
  • Implemented an enhanced error check to prevent recursive calls that could lead to infinite loops or system instability, ensuring that the application handles such cases more robustly without impacting valid functionality.

[coderabbitai]

Walkthrough

This pull request adds a check within the append_subprograms method of the program_reader_t class to prevent recursive subprogram calls. If a subprogram is detected to be the same as the calling program (prog), an UnmarshalError is thrown. The new logic complements the existing process of appending valid subprograms without altering public declarations.

Changes

File(s)	Change Summary
src/asm_files.cpp	Introduced a check in the append_subprograms method to detect and block recursive subprogram calls by throwing an UnmarshalError if triggered.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9305b23 and a1abc26.

📒 Files selected for processing (1)

• src/asm_files.cpp (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: build_windows (Debug, tests)
• GitHub Check: build_windows (Debug, library)
• GitHub Check: build_ubuntu (Release, tests)
• GitHub Check: build_ubuntu (Debug, tests)
• GitHub Check: build_windows (Release, library)
• GitHub Check: build_windows (Release, tests)
• GitHub Check: Analyze (cpp)
• GitHub Check: build_ubuntu (Release)
• GitHub Check: build_ubuntu (Debug)

🔇 Additional comments (1)

src/asm_files.cpp (1)

381-385: Good addition to prevent recursive subprograms.

The added check prevents unbounded memory allocation when a subprogram refers to itself, which addresses the issue described in the PR. This is a critical fix that avoids potential out-of-memory errors when processing malformed eBPF programs.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

coverage: 88.177% (-0.02%) from 88.194%
when pulling a1abc26 on Alan-Jowett:issue851
into 9305b23 on vbpf:main.