chore: export framework components for use in independent pages #6245
Conversation
zwtvip
requested review from
anncwb,
vince292007,
mynetfan and
jinmao88
as code owners
|
WalkthroughTwo new components, Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
packages/effects/common-ui/src/components/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Check (ubuntu-latest)
- GitHub Check: Check (windows-latest)
- GitHub Check: Lint (windows-latest)
- GitHub Check: Lint (ubuntu-latest)
- GitHub Check: Test (windows-latest)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: post-update (ubuntu-latest)
- GitHub Check: post-update (windows-latest)
| @@ -17,13 +17,15 @@ export { | |||
| VbenAvatar, | |||
| VbenButton, | |||
| VbenButtonGroup, | |||
| VbenCheckbox, | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify the existence of VbenCheckbox in the source package
Ensure that VbenCheckbox is actually exported by @vben-core/shadcn-ui and, if so, update any relevant documentation or storybook entries to reflect this new export.
Please run the following script to confirm the export:
🏁 Script executed:
#!/bin/bash
# Verify that VbenCheckbox is exported from @vben-core/shadcn-ui
grep -R "export.*VbenCheckbox" node_modules/@vben-core/shadcn-ui || echo "VbenCheckbox not found in @vben-core/shadcn-ui"Length of output: 236
Missing export for VbenCheckbox – please correct the source or remove it
The grep check failed because node_modules/@vben-core/shadcn-ui doesn’t exist, so we can’t confirm that VbenCheckbox is exported. Please:
- Verify that the package name and version in
packages/effects/common-ui/package.jsonmatch the one that should provideVbenCheckbox. - If the correct package is something else (e.g.
@vben/shadcn-ui), update the import/export path accordingly. - If no package actually exports
VbenCheckbox, remove it frompackages/effects/common-ui/src/components/index.ts(line 20) or replace it with the proper component.
🤖 Prompt for AI Agents
In packages/effects/common-ui/src/components/index.ts at line 20, the component
VbenCheckbox is exported but the source package @vben-core/shadcn-ui does not
exist or does not export it. Verify the correct package name and version in
packages/effects/common-ui/package.json to ensure it matches the intended
source. If the correct package is different, update the import/export path
accordingly. If no package exports VbenCheckbox, remove it from the export list
or replace it with the correct component.
| VbenCheckButtonGroup, | ||
| VbenCountToAnimator, | ||
| VbenFullScreen, | ||
| VbenInputPassword, | ||
| VbenLoading, | ||
| VbenLogo, | ||
| VbenPinInput, | ||
| VbenSelect, |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify the existence of VbenSelect in the source package
Ensure that VbenSelect is actually exported by @vben-core/shadcn-ui and, if so, update any relevant documentation or storybook entries to reflect this new export.
Please run the following script to confirm the export:
🏁 Script executed:
#!/bin/bash
# Verify that VbenSelect is exported from @vben-core/shadcn-ui
grep -R "export.*VbenSelect" node_modules/@vben-core/shadcn-ui || echo "VbenSelect not found in @vben-core/shadcn-ui"Length of output: 230
🏁 Script executed:
#!/bin/bash
set -e
echo "Modules in node_modules matching 'vben':"
ls node_modules | grep vben || echo "No modules prefixed with 'vben' found"
echo
echo "Contents of node_modules/@vben-core (if exists):"
ls node_modules/@vben-core || echo "Directory node_modules/@vben-core not found"
echo
echo "Looking for '@vben-core/shadcn-ui' in package manifests:"
grep -R "\"@vben-core/shadcn-ui\"" -n package.json package-lock.json yarn.lock || echo "No reference to '@vben-core/shadcn-ui' in lock files"
echo
echo "Searching the codebase for any usage of 'VbenSelect':"
rg "VbenSelect" -n . || echo "No occurrences of 'VbenSelect' found in the codebase"Length of output: 1779
🏁 Script executed:
#!/bin/bash
# Determine the package name in shadcn-ui package.json
grep -R "\"name\"" -n packages/@core/ui-kit/shadcn-ui/package.json || echo "package.json not found"
# Inspect exports field and main/module entries
grep -R "\"exports\"" -n packages/@core/ui-kit/shadcn-ui/package.json || echo "No exports field"
grep -R "\"main\"" -n packages/@core/ui-kit/shadcn-ui/package.json
grep -R "\"module\"" -n packages/@core/ui-kit/shadcn-ui/package.jsonLength of output: 433
🏁 Script executed:
#!/bin/bash
echo "===== package.json (lines 1-80) ====="
sed -n '1,80p' packages/@core/ui-kit/shadcn-ui/package.json || echo "Cannot read package.json"
echo
echo "===== src/index.ts (entire file) ====="
sed -n '1,200p' packages/@core/ui-kit/shadcn-ui/src/index.ts || echo "Cannot read src/index.ts"
echo
echo "===== Components directory structure ====="
find packages/@core/ui-kit/shadcn-ui/src/components -maxdepth 2 -type f -print || echo "Cannot read components directory"Length of output: 6475
✅ VbenSelect export confirmed
VbenSelect is indeed exported from @vben-core/shadcn-ui (see src/components/select/index.ts). No code changes are required—please update any downstream documentation or Storybook stories to include usage examples for this component.
Areas to update (examples):
- Component reference in your docs folder
- Storybook entry for “Select” under your UI kit stories
🤖 Prompt for AI Agents
In packages/effects/common-ui/src/components/index.ts at line 28, the export of
VbenSelect from @vben-core/shadcn-ui is confirmed to be valid. No code changes
are needed here. Instead, update any relevant documentation and Storybook
stories to include VbenSelect usage examples, ensuring downstream references
reflect this new export.
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit