fix: delete useless code

[pzzyf]

Eliminate redundant async keyword in the router's beforeEach guard to streamline the code.

Summary by CodeRabbit

• Refactor
  • Improved navigation performance by making route guards more efficient and synchronous across multiple applications.
• Bug Fixes
  • Enhanced reliability of page loading indicators during navigation.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 40efc09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The updates remove the async keyword from the callback functions passed to router.beforeEach within the setupCommonGuard function across multiple router guard files. The navigation guard logic remains unchanged and now executes synchronously rather than asynchronously. No changes were made to exported or public entity signatures.

Changes

File(s)	Change Summary
apps/web-antd/src/router/guard.ts apps/web-ele/src/router/guard.ts apps/web-naive/src/router/guard.ts playground/src/router/guard.ts	Removed the async keyword from the callback in router.beforeEach within setupCommonGuard, making the function synchronous. No logic or signature changes.

Poem

A hop and a skip, async is gone,
Now guards are quick, they simply move on.
No waiting in line, the routes all agree,
Synchronous checks—how swift they can be!
With every new path, the progress bar shines,
The rabbit approves—these changes are fine!
🐇✨

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84ef207 and 40efc09.

📒 Files selected for processing (4)

• apps/web-antd/src/router/guard.ts (1 hunks)
• apps/web-ele/src/router/guard.ts (1 hunks)
• apps/web-naive/src/router/guard.ts (1 hunks)
• playground/src/router/guard.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: Check (windows-latest)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: Test (windows-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: post-update (windows-latest)
• GitHub Check: post-update (ubuntu-latest)

🔇 Additional comments (4)

apps/web-ele/src/router/guard.ts (1)

21-21: Proper removal of unnecessary async keyword

Removing the async keyword is appropriate here since this navigation guard doesn't contain any asynchronous operations (no await statements). This improves code clarity and slightly reduces overhead by avoiding the unnecessary Promise wrapping that happens with async functions.

apps/web-naive/src/router/guard.ts (1)

21-21: Clean code improvement - removing unnecessary async

Good cleanup. The function contains no asynchronous operations, so the async keyword was redundant. This change makes the code more accurate while maintaining the same functionality.

apps/web-antd/src/router/guard.ts (1)

21-21: Code optimization by removing redundant async

Well done. Removing the unnecessary async keyword is a good practice when the function has no asynchronous operations. This helps maintain code clarity and reduces the implicit Promise wrapping overhead.

playground/src/router/guard.ts (1)

21-21: Consistent cleanup of redundant async keyword

Good job maintaining consistency across all platform implementations. Like the other files, this change correctly removes an unnecessary async keyword from a synchronous operation, leading to cleaner and more accurate code.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pzzyf]

@jinmao88 cc