-
Notifications
You must be signed in to change notification settings - Fork 7.7k
refactor: modify the default homepage path loaded from the preference… #6099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s.ts Signed-off-by: aonoa <[email protected]>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThis change refactors the handling of the application's default home path across multiple projects and packages. The previously used constant Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Router
participant Preferences
participant AuthStore
User->>Router: Initiates login or accesses root route
Router->>Preferences: Retrieve app.defaultHomePath
Preferences-->>Router: Return defaultHomePath (e.g., '/analytics')
Router->>AuthStore: Complete login or redirect logic
AuthStore->>Router: Use preferences.app.defaultHomePath for redirect
Router->>User: Redirects user to default home path
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…s.ts Signed-off-by: aonoa <[email protected]>
complete issues 5659
Description
Type of change
Please delete options that are not relevant.
Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit
New Features
Documentation
defaultHomePath
preference and its usage.Refactor