fix: add triggerClass binding to PopoverTrigger and update icon-picker styles

[mynetfan]

• Popover支持设置trigger的样式
• 修正icon-picker的input值更新

fixed: #6065

Summary by CodeRabbit

• New Features
  • Added support for customizing the CSS classes of the popover trigger via a new optional property.
• Style
  • Popover content and trigger in the icon picker now use full width styling for improved appearance.
• Bug Fixes
  • Ensured that the icon picker’s internal selection stays synchronized with the input value when updated.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5ca9c03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

A new optional prop, triggerClass, was introduced to the popover component in the UI kit, allowing external customization of the trigger element's CSS classes. In the icon picker component, the popover's content and trigger now use full-width styling by adding the w-full class. Additionally, the icon picker component now synchronizes its internal selection state with the input component's model value by listening for update events, specifically when the type is set to 'input'.

Changes

File(s)	Change Summary
packages/@core/ui-kit/shadcn-ui/src/components/popover/popover.vue	Added optional triggerClass prop for customizing the trigger's CSS class; bound it to <PopoverTrigger>.
packages/effects/common-ui/src/components/icon-picker/icon-picker.vue	Added w-full styling to popover content and trigger; synchronized internal state with input's model value.

Assessment against linked issues

Objective	Addressed	Explanation
Fix IconPicker clearing issue with Element UI input component (#6065)	✅	Internal state currentSelect is updated via input's update event, enabling clearing.

Suggested reviewers

• anncwb
• jinmao88
• vince292007

Poem

In the garden of code where popovers bloom,
A trigger now wears a custom costume.
Icons align, stretching wide with pride,
As input and picker walk side by side.
Rabbits rejoice, their tails held high—
For UI tweaks make the user sigh!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0599f4b and 5ca9c03.

📒 Files selected for processing (1)

• packages/effects/common-ui/src/components/icon-picker/icon-picker.vue (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/effects/common-ui/src/components/icon-picker/icon-picker.vue

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Check (windows-latest)
• GitHub Check: Test (windows-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: post-update (windows-latest)
• GitHub Check: post-update (ubuntu-latest)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0517a70 and 0599f4b.

📒 Files selected for processing (2)

• packages/@core/ui-kit/shadcn-ui/src/components/popover/popover.vue (3 hunks)
• packages/effects/common-ui/src/components/icon-picker/icon-picker.vue (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: Check (windows-latest)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: Test (windows-latest)
• GitHub Check: post-update (ubuntu-latest)
• GitHub Check: post-update (windows-latest)

🔇 Additional comments (4)

packages/@core/ui-kit/shadcn-ui/src/components/popover/popover.vue (3)

24-24: Good addition: new triggerClass prop for styling flexibility

Adding this optional triggerClass prop enhances the component's styling flexibility by allowing external customization of the trigger element's CSS classes.

---

36-37: LGTM: Proper prop exclusion from forwarding

Correctly excluding the new triggerClass from the forwarded props, following the same pattern as the other class props.

---

48-48: LGTM: Proper binding of triggerClass to PopoverTrigger

The triggerClass is correctly bound to the PopoverTrigger component, allowing external style customization.

packages/effects/common-ui/src/components/icon-picker/icon-picker.vue (1)

174-175: Good styling improvement: Full-width popover elements

Adding w-full to both content and trigger classes ensures consistent full-width rendering, enhancing the component's appearance and layout consistency.