fix: lock state will not change overflow style in drawer and modal

[mynetfan]

• Modal和Drawer的锁定状态不再修改overflow样式

fixed: #6064

Summary by CodeRabbit

• Refactor
  • Updated loading and submitting states in popups and modals to disable user interaction using pointer events, rather than hiding overflow.
  • Loading spinner is now displayed outside the scrollable content area for better visibility.
  • Automatic scrolling to top during loading or submitting has been disabled.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 317aeee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes modify the behavior of modal and drawer UI components during loading and submitting states. The automatic scroll-to-top effect when loading or submitting is triggered has been disabled by commenting out the respective watchers. The CSS class applied during these states now uses pointer-events-none to block user interaction, instead of overflow-hidden. Additionally, the loading spinner component has been repositioned outside the scrollable content wrapper and simplified in its class usage. These updates affect how the UI responds visually and interactively when loading or submitting.

Changes

File(s)	Change Summary
packages/@core/ui-kit/popup-ui/src/drawer/drawer.vue .../modal/modal.vue	Disabled automatic scroll-to-top on loading/submitting by commenting out watchers. Changed class binding from overflow-hidden to pointer-events-none for loading/submitting states. Moved and simplified the loading spinner component outside the content wrapper.

Assessment against linked issues

Objective	Addressed	Explanation
Prevent modal content width "jitter" caused by scrollbar appearing/disappearing during lock/unlock (#6064)	✅

Poem

A spinner now floats just outside the frame,
While pointer events rest, the scroll stays the same.
No more jitter or scrollbars that dance,
The modal and drawer hold steady their stance.
Loading and submitting, the UI feels light—
A rabbit’s delight in a modal done right!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca94ca9 and 317aeee.

📒 Files selected for processing (2)

• packages/@core/ui-kit/popup-ui/src/drawer/drawer.vue (2 hunks)
• packages/@core/ui-kit/popup-ui/src/modal/modal.vue (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: Lint (windows-latest)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: Test (windows-latest)
• GitHub Check: Check (windows-latest)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: post-update (windows-latest)
• GitHub Check: post-update (ubuntu-latest)

🔇 Additional comments (6)

packages/@core/ui-kit/popup-ui/src/drawer/drawer.vue (3)

85-95: Improved UX by removing automatic scroll to top during loading

Removing this watcher prevents the drawer from scrolling to the top when loading begins, allowing users to maintain their current scroll position - a significant improvement to user experience.

---

269-270: Better interaction handling during lock states

Replacing overflow-hidden with pointer-events-none is a smart approach that:

1. Maintains visual consistency by keeping scrollbars visible
2. Still prevents user interaction during loading/submitting states
3. Allows users to see the full content without hiding overflow

This directly addresses the issue where lock state was inappropriately changing overflow styles.

---

275-275: Improved loading indicator placement

Moving the loading spinner outside the scrollable wrapper ensures it remains visible regardless of scroll position, while removing the unnecessary size-full class simplifies the component.

packages/@core/ui-kit/popup-ui/src/modal/modal.vue (3)

126-136: Improved UX by removing automatic scroll to top during loading/submitting

Commenting out this watcher prevents the modal from forcibly scrolling to the top when loading or submitting begins, allowing users to maintain their current scroll position and improving the overall user experience.

---

277-278: Better interaction handling during lock states

Replacing overflow-hidden with pointer-events-none is an excellent solution that:

1. Maintains the visibility of scrollbars for better visual consistency
2. Still prevents user interaction during loading/submitting states
3. Allows users to see all content without hiding overflow

This directly addresses the issue where lock state was incorrectly changing overflow styles.

---

283-283: Improved loading indicator placement

Moving the loading spinner outside the scrollable wrapper ensures it remains visible regardless of scroll position, while simplifying the component for better maintainability.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.