Skip to content

chore: update dependency version for improved stability and compatibility #6023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2025

Conversation

anncwb
Copy link
Collaborator

@anncwb anncwb commented Apr 23, 2025

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Bug Fixes

    • Updated stylelint configuration to disable warnings for deprecated at-rules.
    • Improved handling of Vue linting configurations for better compatibility and stability.
  • Style

    • Reordered CSS properties in multiple components for consistency; no impact on appearance or functionality.
    • Updated word-breaking behavior in JSON viewer for improved text wrapping.
  • Chores

    • Upgraded various dependencies and tools to their latest versions for improved reliability and security.
    • Updated esbuild package version for enhanced build performance.
  • Enhancements

    • Made multiple component props optional with default values to increase flexibility and ease of use.

Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: 16fec28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Apr 23, 2025

Walkthrough

This update includes dependency version bumps in the workspace and package configuration files, adjustments to Stylelint and ESLint Vue configurations, and minor reordering of CSS property declarations in several Vue component style blocks. The ESLint Vue config now uses new constants for plugin configs, removes a specific Vue rule, and applies optional chaining for safer property access. The Stylelint config disables a deprecated at-rule warning. CSS changes across components are limited to reordering properties and, in one case, replacing word-break with overflow-wrap for improved word wrapping. A linting rule disabling comment was added in a utility file. A simplification was made in a function clearing reactive points. Several Vue component prop types were changed from required to optional with default values. No changes were made to the signatures of exported or public entities except for these prop optionality adjustments.

Changes

File(s) Change Summary
internal/lint-configs/eslint-config/src/configs/vue.ts Refactored to use new constants for plugin configs, removed a Vue rule, and made property access optional.
internal/lint-configs/stylelint-config/index.mjs Added 'at-rule-no-deprecated': null to disable the deprecated at-rule warning.
package.json Updated esbuild version in pnpm.overrides from 0.24.0 to 0.25.3.
pnpm-workspace.yaml Bumped versions for multiple dependencies in the catalog section; no structural changes.
packages/@core/ui-kit/menu-ui/src/components/menu.vue Reordered CSS properties within SCSS mixins/selectors; no semantic or behavioral changes.
packages/effects/common-ui/src/components/json-viewer/style.scss Reordered color property and replaced word-break: break-word with overflow-wrap: break-word in .jv-string.
packages/effects/common-ui/src/components/resize/resize.vue Reordered CSS properties in .resize.active::before; no change to logic or behavior.
packages/effects/layouts/src/widgets/theme-toggle/theme-button.vue Reordered CSS properties in .theme-toggle__sun and .theme-toggle__sun-beams selectors.
packages/@core/base/shared/src/utils/inference.ts Added ESLint disable comment for vue/prefer-import-from-vue rule; no logic changes.
packages/effects/common-ui/src/components/captcha/hooks/useCaptchaPoints.ts Simplified array clearing in clearPoints function by removing explicit delete count in splice call.
packages/@core/ui-kit/menu-ui/src/components/sub-menu-content.vue Changed isMenuMore prop from required to optional with default false.
packages/@core/ui-kit/shadcn-ui/src/components/segmented/segmented.vue Changed tabs prop from required to optional with default empty array.
packages/effects/common-ui/src/ui/authentication/login.vue Changed formSchema prop from required to optional.
packages/effects/common-ui/src/ui/authentication/register.vue Changed formSchema prop from required to optional with default empty array.
packages/effects/common-ui/src/ui/dashboard/analysis/analysis-charts-tabs.vue Changed tabs prop from required to optional with default empty array.
packages/effects/common-ui/src/ui/dashboard/analysis/analysis-overview.vue Changed items prop from required to optional with default empty array.
packages/effects/common-ui/src/ui/dashboard/workbench/workbench-project.vue Changed items prop from required to optional with default empty array.
packages/effects/common-ui/src/ui/dashboard/workbench/workbench-quick-nav.vue Changed items prop from required to optional with default empty array.
packages/effects/common-ui/src/ui/dashboard/workbench/workbench-todo.vue Changed items prop from required to optional with default empty array.
packages/effects/common-ui/src/ui/dashboard/workbench/workbench-trends.vue Changed items prop from required to optional with default empty array.
packages/effects/layouts/src/basic/copyright/copyright.vue Changed companyName and date props from required to optional with default values.
packages/effects/layouts/src/basic/menu/extra-menu.vue Changed menus prop from required to optional with default empty array.
packages/effects/layouts/src/basic/menu/menu.vue Changed menus prop from required to optional with default empty array.
packages/effects/layouts/src/widgets/global-search/global-search.vue Changed menus prop from required to optional with default empty array.
packages/effects/layouts/src/widgets/global-search/search-panel.vue Changed keyword and menus props from required to optional with default values.
packages/effects/layouts/src/widgets/preferences/blocks/checkbox-item.vue Changed items prop from required to optional with default empty array.
packages/effects/layouts/src/widgets/preferences/blocks/toggle-item.vue Changed items prop from required to optional with default empty array.
packages/effects/plugins/src/vxe-table/use-vxe-grid.ts Moved inheritAttrs: false property within component options object; formatting only.

Poem

A hop, a skip, a version bump or two,
CSS lines shuffled—now fresh, now new!
Linting rules tuned with a gentle paw,
Deprecated warnings? Gone—hurrah!
With every update, this rabbit grins,
For tidy code is where true magic begins.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6afb611 and 16fec28.

📒 Files selected for processing (18)
  • packages/@core/ui-kit/menu-ui/src/components/sub-menu-content.vue (1 hunks)
  • packages/@core/ui-kit/shadcn-ui/src/components/segmented/segmented.vue (1 hunks)
  • packages/effects/common-ui/src/ui/authentication/login.vue (1 hunks)
  • packages/effects/common-ui/src/ui/authentication/register.vue (1 hunks)
  • packages/effects/common-ui/src/ui/dashboard/analysis/analysis-charts-tabs.vue (1 hunks)
  • packages/effects/common-ui/src/ui/dashboard/analysis/analysis-overview.vue (1 hunks)
  • packages/effects/common-ui/src/ui/dashboard/workbench/workbench-project.vue (1 hunks)
  • packages/effects/common-ui/src/ui/dashboard/workbench/workbench-quick-nav.vue (1 hunks)
  • packages/effects/common-ui/src/ui/dashboard/workbench/workbench-todo.vue (1 hunks)
  • packages/effects/common-ui/src/ui/dashboard/workbench/workbench-trends.vue (1 hunks)
  • packages/effects/layouts/src/basic/copyright/copyright.vue (1 hunks)
  • packages/effects/layouts/src/basic/menu/extra-menu.vue (1 hunks)
  • packages/effects/layouts/src/basic/menu/menu.vue (1 hunks)
  • packages/effects/layouts/src/widgets/global-search/global-search.vue (1 hunks)
  • packages/effects/layouts/src/widgets/global-search/search-panel.vue (1 hunks)
  • packages/effects/layouts/src/widgets/preferences/blocks/checkbox-item.vue (1 hunks)
  • packages/effects/layouts/src/widgets/preferences/blocks/toggle-item.vue (1 hunks)
  • packages/effects/plugins/src/vxe-table/use-vxe-grid.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/effects/plugins/src/vxe-table/use-vxe-grid.ts
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: post-update (windows-latest)
  • GitHub Check: post-update (ubuntu-latest)
  • GitHub Check: Check (ubuntu-latest)
  • GitHub Check: Lint (windows-latest)
  • GitHub Check: Test (windows-latest)
  • GitHub Check: Check (windows-latest)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Lint (ubuntu-latest)
🔇 Additional comments (24)
packages/@core/ui-kit/menu-ui/src/components/sub-menu-content.vue (1)

13-13: Type definition improved to match implementation

Making isMenuMore optional with the ? modifier aligns the TypeScript interface with the actual component behavior, as this prop already has a default value of false in the withDefaults call on line 21. This change improves type safety without altering runtime behavior.

packages/effects/common-ui/src/ui/dashboard/analysis/analysis-overview.vue (1)

15-15: Type definition improved to match implementation

Making items optional with the ? modifier aligns the TypeScript interface with the actual component behavior, as this prop already has a default empty array in the withDefaults call on line 23. This change improves type safety without altering runtime behavior.

packages/effects/layouts/src/widgets/preferences/blocks/toggle-item.vue (1)

10-10: Type definition improved to match implementation

Making items optional with the ? modifier aligns the TypeScript interface with the actual component behavior, as this prop already has a default empty array in the withDefaults call on line 12. This change improves type safety without altering runtime behavior.

packages/effects/layouts/src/widgets/preferences/blocks/checkbox-item.vue (1)

17-17: Type definition improved to match implementation

Making items optional with the ? modifier aligns the TypeScript interface with the actual component behavior, as this prop already has a default empty array in the withDefaults call on line 25. This change improves type safety without altering runtime behavior.

packages/@core/ui-kit/shadcn-ui/src/components/segmented/segmented.vue (2)

13-13: Type improvements for better prop optionality and defaults

Making the tabs prop optional aligns with its default value implementation, improving the component's API by making the TypeScript interface match the actual usage pattern.


16-19: Proper default handling of the tabs prop

The default empty array is correctly implemented as a function to avoid sharing the same array instance across component instances. This approach is a Vue best practice.

packages/effects/common-ui/src/ui/dashboard/analysis/analysis-charts-tabs.vue (3)

9-9: Type improvements for better prop optionality and defaults

Making the tabs prop optional aligns with its default value implementation, improving type safety and component API clarity.


16-18: Properly implemented default value with function return

The default empty array is correctly implemented as a function return to avoid shared references between component instances.


20-22: Safe property access with optional chaining

The code correctly uses optional chaining (?.) when accessing the tabs array elements, which provides additional safety when working with empty or undefined arrays.

packages/effects/layouts/src/basic/copyright/copyright.vue (2)

3-3: Type improvements for better prop optionality

Making the companyName prop optional with the ? suffix aligns with the withDefaults implementation on line 15, improving the component's TypeScript interface.


5-5: Type improvements for better prop optionality

Making the date prop optional improves the component's API by making the TypeScript interface match the actual usage pattern with defaults.

packages/effects/common-ui/src/ui/authentication/login.vue (3)

20-20: Type improvements for better prop optionality and defaults

Making the formSchema prop optional with the ? suffix is a good type-level improvement that aligns with its default implementation.


27-43: Comprehensive defaults with proper array initialization

The component has well-structured defaults for all props, including the now optional formSchema. The empty array default is correctly implemented as a function to avoid sharing references between component instances.


55-55: Safe reactive binding with computed properties

The component safely uses the formSchema prop through a computed property, ensuring that changes to the prop are properly reflected in the form.

packages/effects/layouts/src/basic/menu/menu.vue (1)

9-9: Type definition properly aligned with default value

Making menus optional in the Props interface correctly aligns the type definition with the default value provided in withDefaults. This is good TypeScript practice in Vue components when props have default values.

packages/effects/common-ui/src/ui/authentication/register.vue (1)

17-17: Type definition properly aligned with default value

Making formSchema optional in the Props interface correctly aligns the type definition with the default value provided in withDefaults. This improves type safety and provides better IDE support when the component is used without explicitly passing this prop.

packages/effects/layouts/src/basic/menu/extra-menu.vue (1)

14-14: Type definition properly aligned with default value

Making menus optional in the Props interface correctly aligns the type definition with the default value provided in withDefaults. This change is consistent with similar updates across other menu-related components in the codebase.

packages/effects/layouts/src/widgets/global-search/search-panel.vue (1)

21-21: Type definitions properly aligned with default values

Making both keyword and menus optional in the Props definition correctly aligns the type definitions with their default values provided in withDefaults. This ensures type safety while allowing these props to be omitted when the component is used.

packages/effects/layouts/src/widgets/global-search/global-search.vue (1)

27-27: LGTM! Making menus prop optional improves component flexibility.

This change makes the menus prop optional while maintaining the default empty array, improving both type safety and component usability without affecting existing implementations.

packages/effects/common-ui/src/ui/dashboard/workbench/workbench-todo.vue (1)

13-13: LGTM! Properly making items prop optional with default.

Making the items prop optional with a default empty array implementation improves component flexibility and is consistent with similar changes across other components in the codebase.

packages/effects/common-ui/src/ui/dashboard/workbench/workbench-project.vue (1)

13-13: LGTM! Good change to make items prop optional.

This change aligns with the pattern applied throughout the codebase, making array props optional with appropriate defaults for better flexibility and type safety.

packages/effects/common-ui/src/ui/dashboard/workbench/workbench-quick-nav.vue (1)

13-13: LGTM! Consistent with other component changes.

Making the items prop optional with a default empty array follows the same pattern applied to other components, creating a more consistent API across the component library.

packages/effects/common-ui/src/ui/dashboard/workbench/workbench-trends.vue (2)

13-13: Good improvement to component API.

Making the items prop optional with the question mark syntax improves the component's flexibility. This change allows the component to be used without explicitly providing the items prop while ensuring it has a safe default value.


21-23: Well-implemented default value.

The withDefaults implementation provides an empty array as the default value, which is the correct approach for an optional array prop. Using an arrow function to return a new array prevents shared references between component instances.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@anncwb anncwb force-pushed the chore/update-dep branch from 8da5583 to f15cc16 Compare April 23, 2025 14:56
@anncwb anncwb merged commit 76de450 into main Apr 27, 2025
14 checks passed
@anncwb anncwb deleted the chore/update-dep branch April 27, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant