fix: alert action button focus, fixed #5921

[mynetfan]

Description

修复Alert组件的按钮焦点切换问题。

fixed #5921

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• Refactor
  • Adjusted the alert dialog buttons to improve responsiveness by conditionally managing their disabled states during operations.
• New Features
  • Enhanced the lightweight alert display with an additional link providing quick access to component documentation.

[changeset-bot]

⚠️ No Changeset found

Latest commit: a5a31f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The pull request updates the rendering of the alert dialog components by adding the as-child prop to both the cancel and action components and relocating the :disabled attribute to an inner component with conditional evaluation based on the loading state. Additionally, a new documentation link slot was added to the lightweight modal example in the playground. No changes were made to the exported or public entities.

Changes

File(s)	Change Summary
packages/@core/.../alert.vue	Added as-child prop to AlertDialogCancel and AlertDialogAction; moved :disabled attribute to inner component for conditional loading state.
playground/.../modal/index.vue	Added a new #extra slot containing a DocButton that links to "/components/common-ui/vben-alert".

Assessment against linked issues

Objective	Addressed	Explanation
Ensure Modal component gains immediate focus on activation [#5921]	❌	No modifications to Modal focus behavior were included.
Prevent double focus on Alert component buttons and correct confirm button activation [#5921]	✅

Poem

I'm a little bunny, hopping through the code,
Tweaking props and slots on this winding road.
With as-child magic, the focus bugs take flight,
Rendered buttons now shine ever so bright.
Hoppy leaps and joyful cheers for a code delight! 🐰✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86da3ce and a5a31f3.

📒 Files selected for processing (2)

• packages/@core/ui-kit/popup-ui/src/alert/alert.vue (2 hunks)
• playground/src/views/examples/modal/index.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Check (windows-latest)
• GitHub Check: Test (windows-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: post-update (windows-latest)
• GitHub Check: post-update (ubuntu-latest)

🔇 Additional comments (4)

playground/src/views/examples/modal/index.vue (1)

264-266: Good addition of documentation link

Adding a documentation link to the lightweight alert dialog example improves user experience by providing direct access to relevant documentation.

packages/@core/ui-kit/popup-ui/src/alert/alert.vue (3)

141-141: Proper fix for the cancel button in the header

Adding the as-child prop to the AlertDialogCancel component ensures proper focus management for nested button components. This addresses the focus issue mentioned in the PR objective.

---

161-170: Correct implementation of button focus handling

The changes here properly address the focus issue by:

1. Adding the as-child prop to ensure proper DOM structure
2. Moving the :disabled attribute from the dialog container to the actual button component

This ensures that the disabled state is applied correctly to the button while maintaining proper focus order, fixing issue #5921.

---

171-179: Consistent use of as-child for action button

Adding the as-child prop to the AlertDialogAction component ensures consistent behavior with the cancel button and proper focus management. Good implementation.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.