fix: missing route data in guard, fixed: #4108 #4114
Conversation
|
WalkthroughThe recent changes enhance the routing logic in the application by ensuring that redirect paths accurately reflect the full URL, including query parameters. By switching from Changes
Sequence Diagram(s)(Sequence diagrams are not applicable for this change as the modifications are too simple.) Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web-antd/src/router/guard.ts (1 hunks)
Additional comments not posted (2)
apps/web-antd/src/router/guard.ts (2)
118-118: LGTM! Verify impact on other routes.The change to use
to.fullPathensures query parameters are preserved, addressing the bug effectively.However, verify that this change doesn't affect other routes adversely.
Verification successful
Change Verified: No Adverse Effects on Other Routes
The change to use
to.fullPathfor redirection ensures query parameters are preserved and does not negatively impact other routes or functionalities. The usage ofto.pathremains appropriate for path checks and loading states.
- The change is consistent with the intended routing logic.
- No conflicts or adverse effects were found in other parts of the router logic.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the change to `to.fullPath` does not adversely affect other routes. # Test: Search for all usages of `to.path` and `to.fullPath` in the router directory to ensure consistent usage. rg --type ts -A 5 $'to.path|to.fullPath' apps/web-antd/src/routerLength of output: 2160
121-121: LGTM! Verify URL decoding accuracy.The use of
decodeURIComponent(redirectPath)ensures the full URL is resolved accurately.Verify that URL decoding does not introduce any issues, particularly with special characters.
Description
此PR解决以下BUG：
直接在浏览器地址栏输入带query的链接来访问，打开页面时query参数会丢失。如：https://www.vben.pro/#/demos/nested/menu1?id=123
未登录状态访问此链接会转到登录页面，登录成功后会重定向时会丢失id=123
已登录状态下访问此链接会被直接重定向到不带query参数的地址
Type of change
Please delete options that are not relevant.
Summary by CodeRabbit