-
Notifications
You must be signed in to change notification settings - Fork 7.7k
chore(vscode): add role ctx highlight #4062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe changes enhance the Visual Studio Code environment by introducing a new extension for custom code color highlighting and adding configuration settings that improve the visibility of access control features. This includes specifying file types for highlighting and defining colors for specific access-related code values, resulting in a more visually intuitive development experience. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .vscode/extensions.json (1 hunks)
- .vscode/settings.json (1 hunks)
Files skipped from review due to trivial changes (1)
- .vscode/extensions.json
Additional comments not posted (3)
.vscode/settings.json (3)
194-194
: LGTM!The file types listed (
vue
,typescript
,markdown
) are appropriate for the intended use case of custom color highlighting.
195-201
: LGTM!The values listed (
v-access:code
,v-access:role
,hasAccessByCodes
,hasAccessByRoles
,AccessControl
) are relevant to access control and appropriately chosen for highlighting.
202-202
: LGTM!The color code
#3b82f6
is appropriate and provides good visibility for the highlighted values.
ci没过,合并下最新代码 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .vscode/extensions.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .vscode/extensions.json
@warmthsea 这个我建议可以添加在文档即可 |
在大型系统中,权限控制可能有数千个,我认为为权限控制添加特殊的 ide 颜色显示是不错的。
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit
New Features
Improvements