Feature/v2 rest client backup #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her branch.. Will remove this commit and add right message for each files then.
- Fix DeleteJob by removing invalid 'type' parameter - Fix UpdateJob to use 'backupNg.editJob' with correct parameters - Improve VM selection safety in RunJobForVMs - Add safety warnings for RunJob to prevent accidental backups This fixes the issue with Terraform provider reporting errors when deleting or updating backup jobs.
- Create structured integration test setup with environment controls - Add tests for VM, backup, snapshot, restore, and other services - Implement BackupTestGuide to prevent accidental backups during testing - Add GitHub workflow for running integration tests - Add integration testing documentation
- Update library interfaces for better testability - Add mock implementations for testing without real XO instance - Add JSONRPC interface for more consistent API interactions
- Extract JSON-RPC functionality into dedicated service - Improve error handling for API calls - Add better parameter validation
- Improve type definitions for better API interactions - Update utility functions for parameter handling - Add tests for core utilities
- Improve VM, snapshot, task, and restore services - Make storage repository service more robust - Update tests for services
- Improve README with clearer instructions - Update examples to demonstrate proper API usage - Update Makefile for better developer experience
- Update Go module dependencies - Fix version conflicts
- Improve backup job payload representation - Update task payload structure for better API compatibility
- Update client initialization and configuration - Enhance error handling in API calls
…n running the cmd
nathanael-h
requested changes
Apr 24, 2025
nathanael-h
reviewed
Apr 24, 2025
gCyrille
reviewed
Apr 28, 2025
28 tasks
…limit and simplify them
gCyrille
reviewed
May 20, 2025
|
|
||
| If you prefer to run commands manually: | ||
|
|
||
| 1. Install mockgen: |
There was a problem hiding this comment.
move the install process before the options
gCyrille
reviewed
May 20, 2025
gCyrille
reviewed
May 20, 2025
gCyrille
reviewed
May 20, 2025
|
@iButcat Can you handle the 2 comments about documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.