Make icon a square, and install to share/icons instead of share/pixmap #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applemayexist
force-pushed
the
icon-loc
branch
from
a9e7573 to
c1df3fe
Compare
applemayexist
force-pushed
the
icon-loc
branch
from
c1df3fe to
342b689
Compare
Flatpak (and presumably other software) only look for icons in share/icons, and so doesn't find the Vanilla icon in its current location.
The icon and gamepad diagram have seperate use cases, and should be seperate images. This allows us to make the icon a square, which many programs expect (including Flatpak), without intefering with the input configuration dialog.
applemayexist
force-pushed
the
icon-loc
branch
from
342b689 to
88675d7
Compare
|
This would probably be useful but needs to be updated for the latest commit. Ultimately an actual icon design would probably be better than just making the current one square. |
I can make one, what style should i go for? A 3d render or an svg? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to package Vanilla in a Flatpak, which only seems to support icons in share/icons. It also seems to be where most apps install their icons. Flatpak also forces icons to be square, so I've increased the height to 600 and centred the gamepad, and created a copy of the original for use in the input configuration dialog.