comply with -Wall #110
Open
comply with -Wall #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__attribute__((format(printf, ...))) tells compilers and linters that this function takes printf style arguments, and allows them to check if there are parameters missing, too many parameters, or parameters of incorrect type
see HEAD~2 for details
|
This would probably be useful but will need to be updated for the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Vanilla comply with -Wall. This has obvious benefits (it will catch trivial dumb bugs), and is a pretty standard baseline from what I've seen. No behaviour was really fixed (most of the issues were just using
unsigned charwithchar1, or unused variables), except forprintf(3)statements that had incorrect parameters and such.This also adds
__attribute__((format))to the printf wrappers. See the first commit for more details.Footnotes
I have just used
uint8_tto leavecharto the domain of text, instead of bytes. ↩