Some query args can be nullable - fixes #8 #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondifon
commented
Apr 29, 2021
yondifon
commented
- Set the argument to be optional fixes Error: op_filter_graphql_connection_query_args() must be of the type array, null given #8
- Set the argument to be optional fixes #8
|
replacing the file with this version breaks my wordpress install (php 7.4), but simply removing the type definition array from line #90 of the original file fixes the issue without breaking things. 👍 wordpress officially supports php 7.4 and later, union types are new to php 8.0 i created a separate pull request with the type removed and verified it works on all supported php versions. thanks for the lead in the right direction. Cheers. |
|
Should be fixed by #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.