Accordion should use cards #1109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tranlamnhatnam
commented
Oct 10, 2016
tranlamnhatnam
commented
- v4 - Accordion example should use cards twbs/bootstrap#17159
- Don't use collapse classes on elements with padding twbs/bootstrap#20870
|
The offical Bootstrap v3 example uses panels, hmmm... http://getbootstrap.com/javascript/#collapse-example-accordion Your commit break the tests :( OK cards are only available in v4... So we must distinguish the code between v3 and v4... |
|
Please have a look at https://github.com/valor-software/ng2-bootstrap/tree/PR1109 I fixed the tests... But no distinction between v3 and v4 :( |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.