Skip to content

Add sentinel_total_tilt to sentinel INFO sentinel #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

carlosfu
Copy link
Contributor

it will be a good idea to add total_tilt in info command to show total tilt count, in order to help admin to know sentinel tilt condition.

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.03%. Comparing base (09f9630) to head (ac632b2).
Report is 17 commits behind head on unstable.

Files with missing lines Patch % Lines
src/sentinel.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1904      +/-   ##
============================================
+ Coverage     71.00%   71.03%   +0.02%     
============================================
  Files           123      123              
  Lines         65675    65706      +31     
============================================
+ Hits          46631    46671      +40     
+ Misses        19044    19035       -9     
Files with missing lines Coverage Δ
src/sentinel.c 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hwware
Copy link
Member

hwware commented Mar 31, 2025

I do not understand why admin need to know the total number of the tilt, tilt is only a status, it can be entered or exited.

@kukey
Copy link
Contributor

kukey commented Apr 1, 2025

@hwware When sentinel enters titl, it will affect the cluster's failover. If the number of entries is too more, in general may need to rebalance the sentinel.

@hwware
Copy link
Member

hwware commented Apr 3, 2025

Please sign your DCO, Thanks

@enjoy-binbin enjoy-binbin changed the title [sentinel] add tilt total count in sentinel info Add sentinel_total_tilt to sentinel INFO sentinel Apr 7, 2025
@enjoy-binbin enjoy-binbin added the major-decision-pending Major decision pending by TSC team label Apr 7, 2025
@enjoy-binbin
Copy link
Member

@valkey-io/core-team Looks like a minor optimization for sentinel, please approval or comment.

carlosfu and others added 2 commits April 8, 2025 11:34
@madolson madolson added needs-doc-pr This change needs to update a documentation page. Remove label once doc PR is open. major-decision-approved Major decision approved by TSC team and removed major-decision-pending Major decision pending by TSC team labels Apr 14, 2025
@hwware
Copy link
Member

hwware commented Apr 14, 2025

@carlosfu Please update the updated-doc PR here, and we will merge this PR, Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-decision-approved Major decision approved by TSC team needs-doc-pr This change needs to update a documentation page. Remove label once doc PR is open.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants