-
Notifications
You must be signed in to change notification settings - Fork 767
Add sentinel_total_tilt to sentinel INFO sentinel #1904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1904 +/- ##
============================================
+ Coverage 71.00% 71.03% +0.02%
============================================
Files 123 123
Lines 65675 65706 +31
============================================
+ Hits 46631 46671 +40
+ Misses 19044 19035 -9
🚀 New features to boost your workflow:
|
I do not understand why admin need to know the total number of the tilt, tilt is only a status, it can be entered or exited. |
@hwware When sentinel enters titl, it will affect the cluster's failover. If the number of entries is too more, in general may need to rebalance the sentinel. |
Please sign your DCO, Thanks |
@valkey-io/core-team Looks like a minor optimization for sentinel, please approval or comment. |
Signed-off-by: carlosfu <[email protected]>
Signed-off-by: Binbin <[email protected]> Signed-off-by: carlosfu <[email protected]>
@carlosfu Please update the updated-doc PR here, and we will merge this PR, Thanks |
it will be a good idea to add total_tilt in info command to show total tilt count, in order to help admin to know sentinel tilt condition.