fix: sink HTTP clients to read proxy config from environment #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Gillson <[email protected]>
Signed-off-by: Tyler Gillson <[email protected]>
dosubot
bot
added
size:XS
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #341 +/- ##
==========================================
+ Coverage 48.62% 48.90% +0.27%
==========================================
Files 22 22
Lines 1273 1274 +1
==========================================
+ Hits 619 623 +4
+ Misses 586 584 -2
+ Partials 68 67 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mattwelke
requested changes
Jul 22, 2024
mattwelke
approved these changes
Jul 22, 2024
TylerGillson
added a commit
that referenced
this pull request
Jul 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.48](v0.0.47...v0.0.48) (2024-07-22) ### Bug Fixes * sink HTTP clients to read proxy config from environment ([#341](#341)) ([ffa327e](ffa327e)) ### Other * **deps:** bump github.com/hashicorp/go-retryablehttp from 0.7.5 to 0.7.7 ([#337](#337)) ([c36994d](c36994d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: Tyler Gillson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#159
Description
Use
http.DefaultClient, rather than constructing our own HTTP client manually. This will load proxy config fromHTTP_PROXY,HTTPS_PROXY, andNO_PROXYenvironment variables by default.Additionally, make failure to load the system cert pool a non-fatal error.