Skip to content

test: scaffold e2e tests #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged

test: scaffold e2e tests #189

merged 2 commits into from
Dec 10, 2024

Conversation

arturshadnik
Copy link
Member

Description

This PR re-scaffolds the project using kubebuilder alpha generate. This is a follow-up to #185.

  • Updates a few things that were missed in the last PR wrt. metrics service
  • Initialize e2e tests. For now, we are only testing basic functionality. The tests should be expanded to cover validator-specific use-cases.

@arturshadnik arturshadnik requested a review from a team as a code owner December 10, 2024 06:42
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement Enhancement to an existing feature labels Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 170 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tests/utils/utils.go 0.00% 159 Missing ⚠️
cmd/main.go 0.00% 11 Missing ⚠️
@@             Coverage Diff             @@
##             main     #189       +/-   ##
===========================================
- Coverage   64.25%   48.45%   -15.81%     
===========================================
  Files           9       10        +1     
  Lines         512      679      +167     
===========================================
  Hits          329      329               
- Misses        164      331      +167     
  Partials       19       19               
Files with missing lines Coverage Δ
api/v1alpha1/maasvalidator_types.go 76.92% <ø> (ø)
internal/controller/maasvalidator_controller.go 57.57% <ø> (ø)
cmd/main.go 0.00% <0.00%> (ø)
tests/utils/utils.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83531a...7869382. Read the comment docs.

Signed-off-by: Artur Shad Nik <[email protected]>
@TylerGillson
Copy link
Member

As you work through all of the plugins, you'll end up duplicating the E2E test helper code many times.

We many want to consider centralizing the test setup utils in the validator repo.

Also, given that we're already using DevSpace, I'm not 100% sold on introducing dev container config.

@TylerGillson TylerGillson merged commit bd9aa47 into main Dec 10, 2024
7 of 8 checks passed
@TylerGillson TylerGillson deleted the chore/re-scaffold branch December 10, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants