test(gossipsub): parameters #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlve
commented
Jun 5, 2025
| @@ -129,7 +129,6 @@ proc setupGossipSubWithPeers*( | |||
|
|
|||
| proc teardownGossipSub*(gossipSub: TestGossipSub, conns: seq[Connection]) {.async.} = | |||
| await allFuturesThrowing(conns.mapIt(it.close())) | |||
| await gossipSub.switch.stop() | |||
There was a problem hiding this comment.
Seems like it wasn't needed. With it we can observe logs:
WRN 2025-06-05 12:34:58.136+01:00 service is already stopped topics="libp2p switch" tid=15516792
WRN 2025-06-05 12:34:58.136+01:00 TCP transport already stopped topics="libp2p tcptransport" tid=15516792
rlve
commented
Jun 5, 2025
|
|
||
| # Then it saves max 1001 messages in the history and the rest is dropped | ||
| check: | ||
| peer.iDontWants[0].len == 1001 |
There was a problem hiding this comment.
Compared to the magic number, as the condition in code is done in the following way:
nim-libp2p/libp2p/protocols/pubsub/gossipsub/behavior.nim
Lines 308 to 309 in 3a7745f
There was a problem hiding this comment.
i'll make this pr tomorrow
vladopajic
approved these changes
Jun 5, 2025
Closed
richard-ramos
approved these changes
Jun 6, 2025
…p2p into test-gossipsub-peremeters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing tests according to the 7. Parameter Configuration Tests
New tests:
"Max IDONTWANT messages per heartbeat per peer""rebalanceMesh Degree Hi - dScore controls number of peers to retain by score when pruning""Unsubscribe backoff"and remove skipped"GossipSub unsub - resub faster than backoff""Prune backoff"New test suits:
"GossipSubParams validation""TopicParams validation"