benchdnn: memory: gpu: enable support for RNG memory fill #3336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:gpu-intel
atkassen
reviewed
May 27, 2025
| } | ||
|
|
||
| uint philox_4x32(long idx, uint seed) { | ||
| return ref_philox_4x32(idx >> 2, seed)[idx & 3]; |
There was a problem hiding this comment.
Suggested change
| return ref_philox_4x32(idx >> 2, seed)[idx & 3]; | |
| return ref_philox_4x32(idx, seed)[~idx & 3L]; |
echeresh
reviewed
May 28, 2025
| #endif | ||
| } else if (is_sycl) { | ||
| #ifdef DNNL_WITH_SYCL | ||
| this->memset(dnnl_mem_default_perf_test_value, size, buffer_index); |
There was a problem hiding this comment.
It would be nice to keep OpenCL/SYCL behavior aligned - otherwise we make performance behavior different between runtimes and performance debugging gets less trivial.
What if we merge the PR but keep the old behavior for OpenCL until we make similar changes for the SYCL runtime?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Systems with data compression enabled by the driver by default wont generate meaningful performance data with
benchdnn ... --mode=FFixes MFDNN-12589
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?