build: add call to find_package(OpenCL) in config.cmake.in #3335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rbiessy
approved these changes
May 27, 2025
|
make test |
|
It seems the clang-tidy check in the CI timed out |
|
make test |
vpirogov
approved these changes
May 29, 2025
AD2605
force-pushed
the
atharva/add_opencl_dependency
branch
from
a28a56e to
6f074a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If building oneDNN, this line is hit during it's CMake configuration, it adds
OpenCL::OpenCLas a target to be available in thednnl-targets.cmakewhich is subsequently installed.Applications which use such a build of oneDNN then require a
find_package(OpenCL)for the target to be exposed which otherwise leads to CMake errors. This dependency is something which is ideally handled by oneDNN, and this PR adds the support for the same.