Skip to content

[CI] remove arm cross compile azure pipelines runners #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Jun 2, 2025

Description

With the addition of arm hardware runners and jobs to GitHub actions CI steps in #3100 (gcc) and #3213 (clang) , the arm-cross compile azure pipelines jobs (#2736 and #2719) can be removed. However, the infrastructure code will be left in place to assist development of oneDAL on Arm, since those scripts are still useful and contain significant overlap with RISC-V emulation support.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@icfaust icfaust added the infra label Jun 2, 2025
@icfaust icfaust marked this pull request as ready for review June 2, 2025 12:35
Copy link
Contributor

@rakshithgb-fujitsu rakshithgb-fujitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also recommend to remove the 2 toolchain files for arm - arm-clang-crosscompile-toolchain.cmake and arm-gnu-crosscompile-toolchain.cmake

@icfaust icfaust merged commit 7b6dfc4 into uxlfoundation:main Jun 10, 2025
22 checks passed
@icfaust icfaust deleted the dev/remove_arm_crosscompiles branch June 10, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants