Skip to content

Add correlation distance algorithm #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Add correlation distance algorithm #3131

wants to merge 39 commits into from

Conversation

richardnorth3
Copy link
Contributor

@richardnorth3 richardnorth3 commented Mar 19, 2025 •
edited
Loading

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@icfaust icfaust marked this pull request as draft March 19, 2025 15:21
@icfaust
Copy link
Contributor

icfaust commented Mar 19, 2025

Hey @richardnorth3 sorry if I overstepped, I marked it as still draft. Make sure to strip out the rbf_kernel from the gpu backend, I assume you'll use the correlation distance primitive for GPU, and make sure to write a fleshed-out description.

Its looking good!

@richardnorth3
Copy link
Contributor Author

Hey @richardnorth3 sorry if I overstepped, I marked it as still draft. Make sure to strip out the rbf_kernel from the gpu backend, I assume you'll use the correlation distance primitive for GPU, and make sure to write a fleshed-out description.

Its looking good!

No, thank you for putting the PR back into draft mode! I accidentally pushed it as a PR and just wanted to merge what changes I had locally in case I lost them. Think the algorithm is mostly finished now and I just have to finish the testing portion.

@richardnorth3 richardnorth3 added dpc++ Issue/PR related to DPC++ functionality new algorithm New algorithm or method in oneDAL oneAPI Issue/PR related to oneAPI part labels Mar 19, 2025
richard.north.iii and others added 18 commits March 19, 2025 16:01
Add clang-format
9ebfbd5 
Signed-off-by: richard.north.iii <[email protected]>
@richardnorth3
Update correlation distance unit test
3c9bc9f 
Signed-off-by: North Iii <[email protected]>
@richardnorth3
Merge branch 'dev/correlation-dist-algo' of https://github.com/richar…
6967809 
…dnorth3/oneDAL into dev/correlation-dist-algo
@richardnorth3
Merge branch 'uxlfoundation:main' into dev/correlation-dist-algo
ba1509e
Update correlation_distance algorithm
abf9734 
Signed-off-by: richard.north.iii <[email protected]>
Merge branch 'dev/correlation-dist-algo' of https://github.com/richar…
0c7edb4 
…dnorth3/oneDAL into dev/correlation-dist-algo
@richardnorth3
Merge branch 'uxlfoundation:main' into dev/correlation-dist-algo
23479cf
Update CPU/GPU correlation distance algorithms
b6f7e78 
Signed-off-by: richard.north.iii <[email protected]>
Merge branch 'dev/correlation-dist-algo' of https://github.com/richar…
a05fe7a 
…dnorth3/oneDAL into dev/correlation-dist-algo
Update cordistance_full_impl.i with clang-format
445161e 
Signed-off-by: richard.north.iii <[email protected]>
Update algo/correlation_distance/BUILD
6d9686e 
Signed-off-by: richard.north.iii <[email protected]>
@richardnorth3
Merge branch 'main' into dev/correlation-dist-algo
97c78e1
@richardnorth3
Update cordistance_lp_impl.i
f90532e
@richardnorth3
Update cordistance_up_impl.i
c9f5b50
@richardnorth3
Merge branch 'uxlfoundation:main' into dev/correlation-dist-algo
abd3be1
Update correlation distance algorithm
de59d01 
Signed-off-by: richard.north.iii <[email protected]>
Merge branch 'dev/correlation-dist-algo' of https://github.com/richar…
3dde3f7 
…dnorth3/oneDAL into dev/correlation-dist-algo
@richardnorth3
Merge branch 'main' into dev/correlation-dist-algo
7d8dfcd
@richardnorth3
Copy link
Contributor Author

/intelci: run

@richardnorth3 richardnorth3 marked this pull request as ready for review May 27, 2025 21:45
Vika-F
Vika-F reviewed May 28, 2025
View reviewed changes
Vika-F
Vika-F reviewed May 28, 2025
View reviewed changes
Vika-F
Vika-F reviewed May 28, 2025
View reviewed changes
Vika-F
Vika-F reviewed May 28, 2025
View reviewed changes
Vika-F
Vika-F reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@Vika-F Vika-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add C++ and DPC++ examples into examples/oneapi folder.
The follow-up ticket about the respective update in the documentation is also needed.

Update correlation distance algo
3b1d439 
Signed-off-by: richard.north.iii <[email protected]>
@richardnorth3
Copy link
Contributor Author

Please also add C++ and DPC++ examples into examples/oneapi folder. The follow-up ticket about the respective update in the documentation is also needed.

To clarify, you are saying to update the documentation in a different PR?

Update examples/oneapi
c386e3b 
Signed-off-by: richard.north.iii <[email protected]>
@ethanglaser
Copy link
Contributor

/intelci: run

@ethanglaser
Copy link
Contributor

Please add a PR description for a change this large - should at least include a brief description of the additions plus clarification on changes to other files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vika-F Vika-F Vika-F left review comments

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

@Alexandr-Solovev Alexandr-Solovev Awaiting requested review from Alexandr-Solovev Alexandr-Solovev is a code owner

@maria-Petrova maria-Petrova Awaiting requested review from maria-Petrova maria-Petrova is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dpc++ Issue/PR related to DPC++ functionality new algorithm New algorithm or method in oneDAL oneAPI Issue/PR related to oneAPI part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardnorth3 @icfaust @ethanglaser @Vika-F