Skip to content

Make match_brackets add to the jumplist #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antoyo
Copy link
Contributor

@antoyo antoyo commented May 14, 2025

Fix #89

@badranX
Copy link
Contributor

badranX commented May 19, 2025

Hi,

Here are some missing Jumplist commands:

search
rsearch
search_next
search_prev
evil_move_paragraph_forward
evil_move_paragraph_backward

I also added this function to push to Jumplist, as save_selection create a status message.

fn evil_save_to_jumplist(cx: &mut Context) {
    let (view, doc) = current!(cx.editor);
    push_jump(view, doc);
}

Maybe, adding EvilCommands::is_enabled in evil_save_to_jumplist ( meaningless untill #72 is fixed). Feel free to add them to this PR.

However, I think creating new evil commands that call the original Helix ones maybe better, because we tend to call Helix commands in evil-helix code expecting the original behavior (beside merging upstream issues). In #102, I tried to do that with macros, but it might be an overkill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

% should add to the jump list
2 participants