-
Notifications
You must be signed in to change notification settings - Fork 4
WIP: Function overlay #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: upmem_release_120
Are you sure you want to change the base?
Conversation
remove lld modifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please amend or comment back.
lld/ELF/LinkerScript.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you find another way of using and implementing OVERLAY command, please remove your change.
lld/ELF/LinkerScript.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you find another way of using and implementing OVERLAY command, please remove your change.
lld/ELF/ScriptParser.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you find another way of using and implementing OVERLAY command, please remove your change.
@@ -50,6 +50,10 @@ | |||
#include "Plugins/Process/POSIX/ProcessPOSIXLog.h" | |||
#include "ThreadDpu.h" | |||
|
|||
extern "C" { | |||
#include <dpu_program.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readjust header includes.
have together the backends includes, (dpu_types.h above)
@@ -94,6 +96,33 @@ RegisterContextDpu::GetRegisterSet(uint32_t set_index) const { | |||
return &g_reg_sets_dpu; | |||
} | |||
|
|||
Status FixPc(ProcessDpu *process, uint32_t *pc) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
abuse \n :)
@@ -578,8 +585,10 @@ size_t ProcessDpu::UpdateThreads() { return m_threads.size(); } | |||
|
|||
Status ProcessDpu::SetBreakpoint(lldb::addr_t addr, uint32_t size, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does function_group feature works with breakpoint now?
No worries if not and WIP status.
if it's not working yet, maybe return a failure if we try to breakpoint in such section would make sense for now?
same apply to unwinding.
it's a very experimental feature we understand.
No description provided.