Skip to content

WIP: Function overlay #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: upmem_release_120
Choose a base branch
from
Open

Conversation

amoisson
Copy link

No description provided.

@amoisson
Copy link
Author

remove lld modifications

@wwolff42 wwolff42 self-requested a review July 31, 2024 13:58
Copy link

@wwolff42 wwolff42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend or comment back.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you find another way of using and implementing OVERLAY command, please remove your change.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you find another way of using and implementing OVERLAY command, please remove your change.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you find another way of using and implementing OVERLAY command, please remove your change.

@@ -50,6 +50,10 @@
#include "Plugins/Process/POSIX/ProcessPOSIXLog.h"
#include "ThreadDpu.h"

extern "C" {
#include <dpu_program.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readjust header includes.
have together the backends includes, (dpu_types.h above)

@@ -94,6 +96,33 @@ RegisterContextDpu::GetRegisterSet(uint32_t set_index) const {
return &g_reg_sets_dpu;
}

Status FixPc(ProcessDpu *process, uint32_t *pc) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abuse \n :)

@@ -578,8 +585,10 @@ size_t ProcessDpu::UpdateThreads() { return m_threads.size(); }

Status ProcessDpu::SetBreakpoint(lldb::addr_t addr, uint32_t size,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does function_group feature works with breakpoint now?
No worries if not and WIP status.
if it's not working yet, maybe return a failure if we try to breakpoint in such section would make sense for now?

same apply to unwinding.
it's a very experimental feature we understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants