Initial changes: Refactor Attention #2156
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @danielhanchen !! I wanted to take a stab at refactoring attention from the puzzles themselves.
Initially, every model is using its own implementation of attention and calls it directly. I took some reference from vLLM's unified attention package that simply uses a
global_attention_variable
to keep track of the currentattention_module
that is being used.Just wanted to run it through you and see if this is good enough to proceed with implementing other
attention_modules
into a similar interface.Thanks.