fix: adjust Recipe Details into a single FeedView #1639
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-wave-0d2d8e10f-1639.eastus2.2.azurestaticapps.net |
3 similar comments
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-wave-0d2d8e10f-1639.eastus2.2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-wave-0d2d8e10f-1639.eastus2.2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-wave-0d2d8e10f-1639.eastus2.2.azurestaticapps.net |
|
|
agneszitte
requested review from
vatsashah45,
rajamatt,
Kunal22shah and
erikvilima
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-wave-0d2d8e10f-1639.eastus2.2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-wave-0d2d8e10f-1639.eastus2.2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-wave-0d2d8e10f-1639.eastus2.2.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-wave-0d2d8e10f-1639.eastus2.2.azurestaticapps.net |
| public async ValueTask Dislike(Review review, CancellationToken ct) => | ||
| await _recipeService.DislikeReview(review, ct); | ||
| public async ValueTask Favorite(RecipeInfo recipeDetails, CancellationToken ct) | ||
| => await _recipeService.Favorite(recipeDetails.Recipe, ct); |
There was a problem hiding this comment.
Should the heart icon change when the favorite button is clicked? The breakpoint is hit but the icon only changes if I leave the page and navigate back to it
There was a problem hiding this comment.
Yes the heart icon should switch upon every click to empty/full. I see we remove the IsFavorited state from the model in this PR, to replace it by using info we already have Recipe.IsFavorite (maybe just a converter problem?).
I remember we had similar issues in the past when making this feature. There might have been a reason we had to create that state, there might be some useful info in the comments on this PR #1195.
There was a problem hiding this comment.
Ah, I probably missed a message to be observed in order to update the recipe feed, will fix
No description provided.