Skip to content

build: remove non existing node.import condition #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

tkjaergaard
Copy link
Contributor

πŸ”— Linked issue

#114

❓ Type of change

Remove the node.import statement from package.json since proxy is only provided in commonJS format, resulting in build errors with Bun.

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Since the proxy is not included in a esm format, it results in the bundlers (Bun in the case of the issue), to throw an error about a missing export.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Thanks for investigation ❀️

@pi0 pi0 changed the title fix: remove node.import statement from ./proxy definition (fixes #114) build: remove non existing node.import condition Feb 7, 2024
@pi0 pi0 merged commit 10563c3 into unjs:main Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants