fix: various fixes #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penalosa
commented
Jan 15, 2025
src/serialization/index.ts
Outdated
| @@ -51,4 +51,5 @@ export { | |||
| Uint8List, | |||
| VoidList, | |||
| Void, | |||
| type _Pointer, | |||
There was a problem hiding this comment.
Without this, some generated .ts files included a _capnp property that referenced a _Pointer that TS couldn't find, causing:
error TS4026: Public static property '_capnp' of exported class has or is using name '_Pointer' from external module but cannot be named
There was a problem hiding this comment.
can we have a test perhaps to avoid regression?
|
@pi0 would you mind taking a look? |
pi0
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of trying to upgrade
workers-sdkto usecapnp-esover the seemingly abandonedcapnp-tsI ran into a few issues withcapnp-es. I've solved them in a way that works for theworkers-sdkuse-case, but that may not fully fit the goals of this library, so I imagine there'll be some back and forth on some of the changes.