Skip to content

Defer "Merging..." response until we actually know we're merging #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

ChrisPenner
Copy link
Member

@ChrisPenner ChrisPenner commented May 14, 2025

Overview

Just a small nit, but pull would previously always print Merging... even on no-op pulls and fast-forwards which is confusing as an end user.

Now it waits until after the No-op and FF checks to say it's going to start a merge.

This does result in it showing "Merging..." in every call to merge though; so maybe we should just remove the message altogether? I'm not sure it's relevant.

Before:

simple/main> pull

  Merging...


  😶

  simple/main was already up-to-date with remote @chrispenner/simple/main.

After:

simple/main> pull

  😶

  simple/main was already up-to-date with remote @chrispenner/simple/main.

Implementation notes

Just move the Merging... response later in the process.

Test coverage

I tried it out

@mitchellwrosen
Copy link
Member

Oops sorry I didn't notice this review request. I'd be more inclined to just remove the message as you mention; that way, neither pull nor merge have weird output. I can make that change on this branch since I took so long to review 👍

@ChrisPenner ChrisPenner requested a review from aryairani May 19, 2025 17:22
@aryairani aryairani merged commit 3444c60 into trunk May 19, 2025
32 checks passed
@aryairani aryairani deleted the cp/honest-merge branch May 19, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants