Defer "Merging..." response until we actually know we're merging #5701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just a small nit, but
pull
would previously always printMerging...
even on no-op pulls and fast-forwards which is confusing as an end user.Now it waits until after the No-op and FF checks to say it's going to start a merge.
This does result in it showing "Merging..." in every call to merge though; so maybe we should just remove the message altogether? I'm not sure it's relevant.
Before:
After:
Implementation notes
Just move the
Merging...
response later in the process.Test coverage
I tried it out