Skip to content

Trigger FZF on no-args ls #5693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2025
Merged

Trigger FZF on no-args ls #5693

merged 5 commits into from
May 14, 2025

Conversation

ChrisPenner
Copy link
Member

@ChrisPenner ChrisPenner commented May 12, 2025

Overview

Makes the argument for ls required, which means it will trigger fzf if not provided.

Interesting/controversial decisions

There's some bike-shedding about whether this is the right place to tweak for allowing a quick exploration of your codebase; but feedback has been good so far, so we'll try this out and go from there.

Test coverage

Transcripts

Loose ends

Currently there's a wart where if there are no namespaces available it will print:

  ⚠️

  Sorry, I was expecting an argument for the namespace, and I couldn't find any to suggest to you. 😅

Rather than:

  nothing to show

Which isn't the best experience, but since creating a new project automatically installs base; basically nobody should be encountering this.

@SystemFw
Copy link
Contributor

I'm absolutely loving this

Copy link
Member

@pchiusano pchiusano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

Let’s merge this whenever you’re ready @ChrisPenner

@ChrisPenner ChrisPenner marked this pull request as ready for review May 14, 2025 16:47
@ChrisPenner ChrisPenner merged commit 02382e4 into trunk May 14, 2025
32 checks passed
@ChrisPenner ChrisPenner deleted the cp/fzf-ls branch May 14, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants