Fix completion on symbols ending in '.' #5676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks -- what was the symptom exactly? |
pchiusano
approved these changes
May 2, 2025
There was a problem hiding this comment.
Nice! Here's an example of the old behavior @aryairani Notice no completions when I request them after List., but if I backspace out the . then it works.
I don't totally get why it also works when I then re-add the .
pchiusano
added
the
ready-to-merge
ChrisPenner
removed
the
ready-to-merge
|
Huh, looks like there's a difference between what's VS Code is deciding to auto-trigger completion on vs what a "manual" trigger of "ctrl-space" does. This version is already better, but I'll fiddle a little more to try to get the best possible setup before I merge :) |
ChrisPenner
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Partial fix for the issue @pchiusano and Baccata were talking about in Discord: https://discord.com/channels/862108724948500490/1200119435931942994/1366397443964665867
Completion just didn't work when your cursor was after a dot, e.g.
List.^Looks like the names parser just didn't like names ending in '.'; now I just strip trailing dots, one line fix.
Test coverage
Nah