Fix calling conventions for Set function replacements #5648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids a transcript change
Just from adding `Set` data type to auto-defined decls.
|
Is there a good way to un-revert the changes this builds on top of? |
|
@dolio You can revert the revert commit |
pchiusano
approved these changes
Apr 8, 2025
This reverts commit 85df4de.
|
🎢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some calling conventions from the recent PR replacing some base
Setfunctions with optimized builtins.The issue was that
Setis a data type wrapper aroundMap, but the functions were acting as if it was just theMapdirectly. The fix is to add theSetdeclaration to the decls module and do some additional (un)wrapping in the foreign functions.Performance is approximately the same on the benchmarks from the last PR.