Add Builtin Checks for Polars Support #1408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AndriiG13 <[email protected]>
AndriiG13
commented
Nov 6, 2023
| @@ -87,7 +87,7 @@ def check_dtype( | |||
|
|
|||
| if schema.dtype is not None: | |||
| obj_dtype = check_obj.schema[schema.name] | |||
| passed = obj_dtype is schema.dtype | |||
| passed = obj_dtype.is_(schema.dtype) | |||
There was a problem hiding this comment.
Because some dtypes objects are in instantiated in the schema, for instance Duration(time_unit="us"), the is comparison doesn't work here. So I used the is_ method provided by the Polars DataType API instead
cosmicBboy
approved these changes
Nov 10, 2023
|
Looks great @AndriiG13 ! Let me know if you need any help with the type engine implementations. |
cosmicBboy
pushed a commit
that referenced
this pull request
Feb 20, 2024
Signed-off-by: AndriiG13 <[email protected]>
cosmicBboy
pushed a commit
that referenced
this pull request
Feb 23, 2024
Signed-off-by: AndriiG13 <[email protected]>
cosmicBboy
pushed a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: AndriiG13 <[email protected]>
cosmicBboy
pushed a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: AndriiG13 <[email protected]>
cosmicBboy
pushed a commit
that referenced
this pull request
Mar 15, 2024
Signed-off-by: AndriiG13 <[email protected]>
max-raphael
pushed a commit
to max-raphael/pandera
that referenced
this pull request
Jan 24, 2025
Signed-off-by: AndriiG13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Polars builtin-checks as per effort to support Polars.
Implements #1421
TODO: