Skip to content

Add isPreferred to single suggestions for autofixing #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

Add isPreferred to single suggestions for autofixing #47

merged 1 commit into from
Jul 27, 2022

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This allows users to fix the issues using auto fix.

Closes #46

@remcohaszing
Specify single expected code actions are preferred
2fd936e 
This allows users to fix the issues using auto fix.

Closes #46
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2022 •
edited
Loading

Codecov Report

Merging #47 (2fd936e) into main (61945c9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          512       514    +2     
=========================================
+ Hits           512       514    +2
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61945c9...2fd936e. Read the comment docs.

@remcohaszing remcohaszing mentioned this pull request Jul 27, 2022
Merged
5 tasks
@wooorm wooorm changed the title Specify single expected code actions are preferred Add isPreferred to single suggestions for autofixing Jul 27, 2022
@wooorm wooorm merged commit 753fa20 into unifiedjs:main Jul 27, 2022
@wooorm wooorm added 🦋 type/enhancement This is great to have 💪 phase/solved Post is done labels Jul 27, 2022
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 27, 2022
@wooorm
Copy link
Member

wooorm commented Jul 27, 2022

Released in 3.1.0!

@remcohaszing remcohaszing deleted the preferred-code-actions branch August 6, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
💪 phase/solved Post is done 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark single expected suggestion as preferred
4 participants
@remcohaszing @codecov-commenter @wooorm @ChristianMurphy