Use bundler for installing dependencies, fix ruby-head issues #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a ridiculous amount of warnings from Ruby 3.4 chilled strings, and also a few errors because of StringIO incompatibility, see ruby/stringio#93 I'm not comfortable setting this to anything else than false. This at least fully keeps the current behaviour
ioquatix
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason CI started failing on ruby-head because
power-assertis not installed. It's bundled, not sure what's going on here and it worked a few days ago. Anyways, bundler makes the workflow nicer overall.I also added frozen string literals to all files. With Ruby 3.4 chilled strings being merged there were a truckload of warnings being emitted, plus a few errors that will be fixed in the future by something along the lines of ruby/stringio#93
The frozen string literals commit can probably be upstreamed relativly painlessly. I would do it myself, but honestly, no idea how to even do that.