-
-
Notifications
You must be signed in to change notification settings - Fork 35
Semantic skeletons design #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aphillips
wants to merge
30
commits into
main
Choose a base branch
from
aphillips-semantic-skeletons-design
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
5180718
Semantic skeletons design
aphillips 239b858
Add links
aphillips 20f623a
Explain picture strings better
aphillips 676f6c9
Update exploration/semantic-skeletons.md
aphillips 289739f
Replace picture output with a table
aphillips e70ad8a
Fix objective section
aphillips c5cf831
Update semantic-skeletons.md
aphillips 902eab7
Fix requirements per comments
aphillips f5de049
Update semantic-skeletons.md
aphillips d2a16a6
Update exploration/semantic-skeletons.md
aphillips 941405b
Update exploration/semantic-skeletons.md
aphillips 5028972
Update exploration/semantic-skeletons.md
aphillips 10bb70d
clarify the picture string table
aphillips 108e5f3
Update exploration/semantic-skeletons.md
aphillips 9d326ec
Add FAQ, improve option bag skeleton description
aphillips b8dabd2
An apostrophe escaped notice
aphillips 3ea7e4d
Update exploration/semantic-skeletons.md
aphillips 0f36d02
Adding use cases and descriptions of types
aphillips 1fb130b
Add an alternative design
aphillips afd0001
Update exploration/semantic-skeletons.md
aphillips a9440d5
Update exploration/semantic-skeletons.md
aphillips ff58cc3
Update exploration/semantic-skeletons.md
aphillips 937c04b
Make `Intl.DateTimeFormat` present tense
aphillips 1beea81
typo
aphillips be26724
Add @eemeli's example
aphillips 7cf129a
Apply suggestion manually (time zone/offset discussion)
aphillips 754c53f
Update exploration/semantic-skeletons.md
aphillips 9f84cba
Start work on 2025-05-12 discussion
aphillips e29b5e2
Add materials about field width specification
aphillips 8f41b5f
Add design from @sffc's comment
aphillips File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.