Skip to content

Add support for custom bakes to databake #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sffc
Copy link
Member

@sffc sffc commented May 11, 2025

Copy link

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@sffc sffc marked this pull request as ready for review May 11, 2025 08:11
@sffc
Copy link
Member Author

sffc commented May 11, 2025

Things I'd like feedback on:

  1. Names of things
  2. The two traits (safe and unsafe) and how they do/don't interact with each other
  3. The unusual safety requirement on the unsafe trait
  4. The new overload on the macro and whether it has any risk of being a breaking change

Comment on lines +38 to +39
/// To bake to a different type than this, use `custom_bake`
/// and implement `CustomBake`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a trait for this is overkill if you can provide a method to the macro

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasons I made it a trait:

  1. Gives a place to enforce the strange safety requirement in the unsafe version
  2. And since we have it for unsafe, we can also use it for safe

How do you suggest handling the safety requirement without a trait?

///
/// #[derive(Bake)]
/// #[databake(path = bar::module)]
/// #[databake(path = custom_bake)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// #[databake(path = custom_bake)]
/// #[databake(custom_bake = Self::bake_to_bytes)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants