-
Notifications
You must be signed in to change notification settings - Fork 213
Add support for custom bakes to databake #6576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Things I'd like feedback on:
|
/// To bake to a different type than this, use `custom_bake` | ||
/// and implement `CustomBake`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having a trait for this is overkill if you can provide a method to the macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reasons I made it a trait:
- Gives a place to enforce the strange safety requirement in the unsafe version
- And since we have it for unsafe, we can also use it for safe
How do you suggest handling the safety requirement without a trait?
/// | ||
/// #[derive(Bake)] | ||
/// #[databake(path = bar::module)] | ||
/// #[databake(path = custom_bake)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// #[databake(path = custom_bake)] | |
/// #[databake(custom_bake = Self::bake_to_bytes)] |
#2452