Segmenter cleanups, part 2 (reduce trait complexity) #6417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First set of followups after #6409
This:
?Sized
from the BreakType traitspreviously the wordbreaktype distinction was awkwardly handled by
unreachable!()
s and trait impls; which meant it was not straightforward to make WordBreak use RuleBreakType instead of WordBreakType. Moving that required moving it to a function, but it seemed to work well.This does not intend to finalize the module structure, it's still doing cleanups, I didn't wish to have these be blocked on module structure decisions.
A cleanup I may make is to use a secondary type parameter on RuleBReakIterator instead of a function pointer. It ought not matter, though.