Unify day-of-week calculation #6368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
previously approved these changes
Mar 27, 2025
Comment on lines
-117
to
-119
| fn day_of_week(&self, date: &Self::DateInner) -> types::Weekday { | ||
| // For the purposes of the calculation here, Monday is 0, Sunday is 6 | ||
| // ISO has Monday=1, Sunday=7, which we transform in the last step |
There was a problem hiding this comment.
This code was originally written by @Manishearth in 67bd340. We later found a bug involving rem_euclid that I fixed in 6899eda.
I don't know why we ever had this code instead of doing the simpler to_fixed().rem_euclid(7) type of approach that you propose in this PR.
Manishearth
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weekdays are not calender-specific, and the current code is overly complex.