Skip to content

Remove JapaneseExtended from DateTimeFormatter::try_new #6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

Remove JapaneseExtended from DateTimeFormatter::try_new #6366

merged 1 commit into from
Mar 27, 2025

Conversation

robertbastian
Copy link
Member

Fixes #4889

@robertbastian robertbastian merged commit 2f5c0e9 into unicode-org:main Mar 27, 2025
28 checks passed
@robertbastian robertbastian deleted the japanex branch March 27, 2025 16:07
@sffc sffc mentioned this pull request Mar 27, 2025
Merged
sffc
sffc reviewed Mar 27, 2025
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks! One quick follow-up: #6370

sffc added a commit that referenced this pull request Mar 27, 2025
@sffc
Remove JapaneseExtended from CalMarkers (#6370)
17517bb 
Follow-up to #6366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@Manishearth Manishearth Manishearth approved these changes

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Now might be a good time to figure out off-the-shelf calendar sets in DateTimeFormatter
3 participants
@robertbastian @sffc @Manishearth